fix: Ensure consistent course card heights on '/courses' page #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a uniform height for all course cards to address UI inconsistencies caused by varying title lengths
…into fix/consistent-course-card-heights
|
@Shrihari10 is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
Modified WebkitLineClamp in titleStyle from 2 to 3 to align title visibility and aesthetics.
kyleecodes
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
LGTM! Course cards are responsive and consistent. Nice use of webkit-box.
I modified webkitlineclamp in titleStyle from 2 to 3 to align title visibilty and aesthetics more with the current design.
Thank you @Shrihari10
Bloom frontend
|
||||||||||||||||||||||||||||
| Project |
Bloom frontend
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 03m 42s |
| Commit |
|
| Committer | Shrihari10 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
9
|
Skipped
|
0
|
Passing
|
77
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1262
What changes did you make and why did you make them?
Did you run tests? Share screenshot of results:
Yes
How did you find us? (GitHub, Google search, social media, etc.):
https://forgoodfirstissue.github.com/